[FIXED] While Loop doesn't break when error is occurred

Issue

I want my while loop to break when there an error, but it doesn't break / close program when it does...

from bs4 import BeautifulSoup

def check_listing_sell():
    counter = 0
    house_counter = 0
    while True:

        url = f"https://www.remax-quebec.com/fr/courtiers-immobiliers/james.he/index.rmx?offset={counter}#listing"
        r = requests.get(url)

        try:
            soup = BeautifulSoup(r.text, "html.parser")

            for item in soup.select("div.property-address"):

                house_counter += 1
                address_prospect = item.get_text(strip=True)
                print(f"{address_prospect} {house_counter}")

            counter += 12
        except Exception as e:
            print(e)
            break


check_listing_sell()

Solution

For some reason, soup.select("div.property-address") returns an empty webelements (not an error) even on 'no results' page. Thus, the condition if len(soup.select("div.property-address")) == 0 should be added. Moreover, placing r = requests.get(url) inside the try block is a decent suggestion.

    while True:

        url = f"https://www.remax-quebec.com/fr/courtiers-immobiliers/james.he/index.rmx?offset={counter}#listing"

        try:
            r = requests.get(url)
            soup = BeautifulSoup(r.text, "html.parser")
            
            if len(soup.select("div.property-address")) == 0:
                break

            for item in soup.select("div.property-address"):

                house_counter += 1
                address_prospect = item.get_text(strip=True)
                print(f"{address_prospect} {house_counter}")

            counter += 12
        except Exception as e:
            print(e)
            break

Answered By - Jobo Fernandez